contract: Fix ability to reorganize contracts #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contextual contract validation can prevent nodes from reorganizing when a conflict occurs for contracts since both chains can confirm the same contract transaction. Original validation occurred before disconnecting the tip of the stale chain and reverting the context examined for the checks.
cyrossignol
changed the title
jamescowens
approved these changes
Oct 17, 2020
jamescowens
added a commit
that referenced
this pull request
Nov 1, 2020
Added - rpc: Add out-of-sync status to "getinfo" and "getblockchaininfo" #1925 (@cyrossignol) - gui: add autocomplete to rpc console #1927 (@Pythonix) - consensus: Add checkpoint post block v11 transition #1919 (@cyrossignol) - researcher: Add -forcecpid configuration option #1935 (@cyrossignol) - gui: Adds detection if version is below last mandatory #1939 (@jamescowens) - contract: Reimplement legacy administrative contract validation #1943 (@cyrossignol) - voting: Add poll choices to "gettransaction" RPC contract output #1948 (@cyrossignol) Changed - doc: Fix link in build-openbsd.md #1924 (@Pythonix) - voting: Decrease poll duration to 90 days #1936 (@cyrossignol) - refactor: Revert init order to fix rejected net messages @1941 (@cyrossignol) - refactor: port amount.h #1937 (@div72) - refactor: Normalize boost::filesystem to fs namespace #1942 (@cyrossignol) - accrual: Apply accrual for new CPIDs from existing snapshots #1944 (@cyrossignol) - accrual: Reset research account when disconnecting first block #1947 (@cyrossignol) Removed - refactor: Clean up transitional code for block version 11 #1933 (@cyrossignol) Fixed - Modify depends packages for openSUSE and other Redhat like distributions and fix mingw bdb53 compile #1932 (@jamescowens) - contract: Fix ability to reorganize contracts #1934 (@cyrossignol) - accrual: Fix snapshot accrual for new CPIDs #1931 (@cyrossignol) - rpc: Clean up getblockstats #1938 (@jamescowens) - scraper, rpc: Correct missing mScraperStats initialization in ConvergedScraperStats (@jamescowens)
jamescowens
added a commit
that referenced
this pull request
Nov 1, 2020
Added - rpc: Add out-of-sync status to "getinfo" and "getblockchaininfo" #1925 (@cyrossignol) - gui: add autocomplete to rpc console #1927 (@Pythonix) - consensus: Add checkpoint post block v11 transition #1919 (@cyrossignol) - researcher: Add -forcecpid configuration option #1935 (@cyrossignol) - gui: Adds detection if version is below last mandatory #1939 (@jamescowens) - contract: Reimplement legacy administrative contract validation #1943 (@cyrossignol) - voting: Add poll choices to "gettransaction" RPC contract output #1948 (@cyrossignol) Changed - doc: Fix link in build-openbsd.md #1924 (@Pythonix) - voting: Decrease poll duration to 90 days #1936 (@cyrossignol) - refactor: Revert init order to fix rejected net messages #1941 (@cyrossignol) - refactor: port amount.h #1937 (@div72) - refactor: Normalize boost::filesystem to fs namespace #1942 (@cyrossignol) - accrual: Apply accrual for new CPIDs from existing snapshots #1944 (@cyrossignol) - accrual: Reset research account when disconnecting first block #1947 (@cyrossignol) Removed - refactor: Clean up transitional code for block version 11 #1933 (@cyrossignol) Fixed - Modify depends packages for openSUSE and other Redhat like distributions and fix mingw bdb53 compile #1932 (@jamescowens) - contract: Fix ability to reorganize contracts #1934 (@cyrossignol) - accrual: Fix snapshot accrual for new CPIDs #1931 (@cyrossignol) - rpc: Clean up getblockstats #1938 (@jamescowens) - scraper, rpc: Correct missing mScraperStats initialization in ConvergedScraperStats (@jamescowens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user observed that contextual contract validation can prevent nodes from reorganizing when a conflict occurs for contract transactions since both chains can confirm the same transaction. The original validation occurred before disconnecting the tip of the stale chain and reverting the context examined for the checks. This moves the offending code to
ConnectBlock()so that a node disconnects the conflicting state before the validation.