Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util, build: Support miniupnp API version 18+ #2771

Conversation

jamescowens
Copy link
Member

The UPNP_GetValidIGD function has added wanaddr and wanaddr length parameters for API version 18+.

The UPNP_GetValidIGD function has added wanaddr and wanaddr length
parameters for API version 18+.
@jamescowens jamescowens requested a review from div72 July 2, 2024 21:28
@jamescowens
Copy link
Member Author

@Tahvok Can you try this on Arch with the miniupnp package that uses API ver 18+?

Copy link
Member

@div72 div72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - compiles on Arch Linux with miniupnpc 2.2.8-1.

@jamescowens jamescowens merged commit 2a53b46 into gridcoin-community:hotfix Jul 3, 2024
14 of 21 checks passed
@jamescowens jamescowens deleted the hotfix_miniupnp_api_ver_18 branch July 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants