Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "gpg" usage to include "--batch" #43

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Dec 5, 2018

See https://bugs.debian.org/913614, especially:

PS i do encourage everyone who is automating the use of gpg to use --batch everywhere, as this forces GnuPG into a mode that is expected to be used for automation (its "API", for lack of a better term, as opposed to its "UI", which is its normal non-batch mode).

Fixes #41
Refs docker-library/official-images#5082

See also docker-library/busybox#55 and linked issues/PRs.

See https://bugs.debian.org/913614, especially:

> PS i do encourage everyone who is automating the use of gpg to use --batch everywhere, as this forces GnuPG into a mode that is expected to be used for automation (its "API", for lack of a better term, as opposed to its "UI", which is its normal non-batch mode).
@keeganwitt
Copy link
Member

keeganwitt commented Dec 7, 2018

I think we might want --no-tty too. The man page says

--no-tty
Make sure that the TTY (terminal) is never used for any output.
This option is needed in some cases because GnuPG sometimes
prints warnings to the TTY even if --batch is used.

The error I saw previously that made me add it in the first place was "gpg: cannot open '/dev/tty': No such device or address" I believe.

@keeganwitt
Copy link
Member

Build is still flaky, even with both args. Last error was "gpg: keyserver receive failed: Cannot assign requested address"

@tianon
Copy link
Contributor Author

tianon commented Dec 10, 2018

Indeed, this PR is not expected to fix any flakiness; this is simply a GnuPG usage fix.

For flakiness suggestions, see docker-library/official-images#4252, especially docker-library/php#666 and linked builds.

@keeganwitt keeganwitt merged commit 26f97c8 into groovy:master Dec 11, 2018
@tianon tianon deleted the gpg-batch branch December 11, 2018 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants