Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta-annotation attributes cause errors in compiler/editor #957

Closed
eric-milles opened this issue Sep 19, 2019 · 1 comment
Closed

Meta-annotation attributes cause errors in compiler/editor #957

eric-milles opened this issue Sep 19, 2019 · 1 comment
Assignees
@eric-milles
Labels
bug
Milestone
v3.5.0

Comments

@eric-milles
Copy link
Member

eric-milles commented Sep 19, 2019 •
edited
Loading

Source and binary references to AnnotationCollector annotations do not handle collector attributes properly.

image

image
@eric-milles eric-milles self-assigned this Sep 19, 2019
@eric-milles
Copy link
Member Author

For binary type references, this check is breaking down: org.eclipse.jdt.internal.compiler.ast.Annotation.isInterestingGroovyType

@eric-milles eric-milles added this to the v3.5.0 milestone Sep 20, 2019
eric-milles added a commit that referenced this issue Sep 20, 2019
@eric-milles
Fix for #957: check for new collector serialize class (Groovy 2.5.3+)
ea55d68
eric-milles added a commit that referenced this issue Sep 22, 2019
@eric-milles
reduce checks for common annotations and propagate compilation abort
34ea574 
#957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-milles eric-milles

Labels
bug
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
1 participant
@eric-milles