Merge pull request #712 from amatsuda/warnings

Ruby Warnings
grosser · Aug 6, 2019 · 2acca17 · 2acca17
2 parents b534735 + 636ca65
commit 2acca17
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/lib/parallel_tests/gherkin/listener.rb b/lib/parallel_tests/gherkin/listener.rb
@@ -10,6 +10,7 @@ class Listener
       def initialize
         @steps, @uris = [], []
         @collect = {}
+        @feature, @ignore_tag_pattern = nil
         reset_counters!
       end
 

diff --git a/lib/parallel_tests/pids.rb b/lib/parallel_tests/pids.rb
@@ -2,7 +2,7 @@
 
 module ParallelTests
   class Pids
-    attr_reader :pids, :file_path, :mutex
+    attr_reader :file_path, :mutex
 
     def initialize(file_path)
       @file_path = file_path

diff --git a/spec/parallel_tests/gherkin/runner_behaviour.rb b/spec/parallel_tests/gherkin/runner_behaviour.rb
@@ -15,7 +15,7 @@ def call(*args)
 
     it "allows to override runner executable via PARALLEL_TESTS_EXECUTABLE" do
       ENV['PARALLEL_TESTS_EXECUTABLE'] = 'script/custom_rspec'
-      should_run_with /script\/custom_rspec/
+      should_run_with(/script\/custom_rspec/)
       call(['xxx'], 1, 22, {})
     end
 

diff --git a/spec/parallel_tests/test/runner_spec.rb b/spec/parallel_tests/test/runner_spec.rb
@@ -475,7 +475,7 @@ def run_with_file(content)
 
     it "prints each stream to the correct stream" do
       skip "open3"
-      out, err = run_with_file("puts 123 ; $stderr.puts 345 ; exit 5") do |path|
+      _out, err = run_with_file("puts 123 ; $stderr.puts 345 ; exit 5") do |path|
         result = call("ruby #{path}", 1, 4, {})
         expect(result).to include({
           :stdout => "123\n",