Rake task passes through additional arguments #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that looks neat / universal :) |
|
v2.23.0 ... some docs for the readme would also be nice, mind making a docs PR ? |
|
We'll get something to you today |
|
This is a great addition, thank you. Allowed us to limit the number of threads to half of what is available on the machine with: rake parallel:spec[,,,'--multiply-processes 0.5']👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed our rake task to use the alternate runtime log option which the CLI provides, but we did not want to plumb through one specific option. Instead we surfaced a pass-through field which allows the rake user to specify any number of arbitrary options to pass along to the CLI.
This allows us to have our rake task specify a different runtime-log.