Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed type module in package.json file to use require #27

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

jimni1222
Copy link
Contributor

@jimni1222 jimni1222 commented Oct 26, 2020

Proposed changes

This PR introduces remove "type": "module" to use require.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

refer standard-things/esm#868
refer https://stackoverflow.com/questions/61401475/why-is-type-module-in-package-json-file
refer https://stackoverflow.com/questions/37132031/node-js-plans-to-support-import-export-es6-ecmascript-2015-modules

@jimni1222 jimni1222 self-assigned this Oct 26, 2020
@jimni1222 jimni1222 merged commit 756bfd1 into ground-x:dev Oct 28, 2020
@jimni1222 jimni1222 deleted the dock branch October 28, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants