Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial refactor & publishing #1

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Conversation

dbushong
Copy link
Member

  • chore: update package setup & lint
  • refactor: move files to std locations

This PR was started by: git wf pr

@@ -1,4 +1,4 @@
Copyright (c) 2015, Groupon, Inc.
Copyright (c) 2019, Groupon, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use a range for year? 2015-2019

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it got published in this year-ish, you don't have to keep updating it, you just need the original year

Copy link
Member

@aotarola aotarola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, LGTM

@dbushong dbushong merged commit 3a47ad9 into master Oct 24, 2019
@dbushong dbushong deleted the dbushong/feature/master/init branch October 24, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants