Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing and foreign PRs in changelog #15

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Conversation

jkrems
Copy link
Collaborator

@jkrems jkrems commented Jan 19, 2016

Fixes #14

@@ -51,9 +51,10 @@ function parseRepository(repositoryField) {
if (match === null) {
throw new Error('Could not parse git repository: ' + repository);
}
var protocol = parsed.protocol === 'http:' ? 'http://' : 'https://';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to have nice local mocks for the Github API without having to mess with https.

@dbushong
Copy link
Member

LGTM

jkrems added a commit that referenced this pull request Jan 19, 2016
Handle missing and foreign PRs in changelog
@jkrems jkrems merged commit 41a1983 into master Jan 19, 2016
@jkrems jkrems deleted the jk-handle-missing-prs branch January 19, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants