Protect merge commit fix by ref id #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbushong
reviewed
Oct 4, 2018
lib/git/commits.js
Outdated
| let mergeRef = data.references.find(ref => { | ||
| return ref.issue === prId; | ||
| }); | ||
| if (mergeRef === null) { |
There was a problem hiding this comment.
Shouldn't this be === undefined?
jkrems
force-pushed
the
jkrems/feature/master/safe-merge-merge
branch
from
9abc433 to
d221f43
Compare
jkrems
force-pushed
the
jkrems/feature/master/safe-merge-merge
branch
from
d221f43 to
0b5d1a6
Compare
dbushong
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle cases where there's multiple references in the commit message and should ensure that the thing we overwrite is the PR reference.
Follow-up to #42