Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use query params for GET requests #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gkoberger
Copy link
Contributor

GET requests are not allowed to have a body, although curl is a bit of a rebel and allows it.

Rather, for GET requests that need to provide options, we should be providing them as params.

In order to maintain backwards compatibility, however, I merge req.body and req.query, with req.query taking precedence.

Hopefully my influx in pull requests is more helpful than it is annoying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant