Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance dummy rate limit interceptor we have. #351

Closed
bwplotka opened this issue Oct 2, 2020 · 2 comments
Closed

Enhance dummy rate limit interceptor we have. #351

bwplotka opened this issue Oct 2, 2020 · 2 comments
Labels

Comments

@bwplotka
Copy link
Collaborator

bwplotka commented Oct 2, 2020

Problem: Current limiter interface does not care about method, metadata (e.g user). So it blocks basic multitenancy use cases.

We also cannot just return something like RateLimited status for client base queuing and retrying logic if needed (:

Let's think it about it more. Also worth to check https://github.com/envoyproxy/ratelimit

cc @yashsharma44

@yashrsharma44
Copy link
Collaborator

Is it fixed by #386 or do we want to add more implementations(provider) for this?

@bwplotka
Copy link
Collaborator Author

This is done thanks to @MalloZup PR indeed 💪🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants