[Rate-limit provider]: Add token bucket implementation of rate-limiter #386

MalloZup · 2021-01-23T09:25:39Z

Use tockenbucket provider

codecov-io · 2021-01-23T09:27:36Z

Codecov Report

Merging #386 (0bb8795) into v2 (a79558a) will decrease coverage by 27.83%.
The diff coverage is 37.48%.

@@             Coverage Diff             @@
##               v2     #386       +/-   ##
===========================================
- Coverage   83.58%   55.74%   -27.84%     
===========================================
  Files          30       37        +7     
  Lines         932     1322      +390     
===========================================
- Hits          779      737       -42     
- Misses        114      514      +400     
- Partials       39       71       +32

Impacted Files	Coverage Δ
chain.go	`0.00% <ø> (-90.91%)`	⬇️
interceptors/auth/auth.go	`100.00% <ø> (ø)`
interceptors/auth/metadata.go	`100.00% <ø> (ø)`
interceptors/ratelimit/ratelimit.go	`50.00% <0.00%> (-50.00%)`	⬇️
interceptors/tags/fieldextractor.go	`13.79% <0.00%> (-71.51%)`	⬇️
testing/testpb/interceptor_suite.go	`0.00% <0.00%> (ø)`
testing/testpb/test.manual_extractfields.pb.go	`0.00% <0.00%> (ø)`
testing/testpb/test.manual_validator.pb.go	`0.00% <0.00%> (ø)`
testing/testpb/test.pb.go	`36.92% <36.92%> (ø)`
interceptors/logging/payload.go	`67.18% <42.30%> (-15.43%)`	⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff779b...0bb8795. Read the comment docs.

MalloZup · 2021-01-23T09:34:49Z

@bwplotka this is the follow-up for the previous PR have look when you have time.

Thx for suggestion and review, no hurry I can wait the weekend I just had some free minutes so I commit-ed it 😁

bwplotka

LGTM, just few suggestions

providers/tokenbucket/doc.go

providers/tokenbucket/examples_test.go

providers/tokenbucket/go.mod

providers/tokenbucket/limiter.go

MalloZup · 2021-01-23T20:59:28Z

thx @bwplotka for review 🌞 . I will check out more in detail tomorrow. enjoy 🍋

google-cla · 2021-01-25T11:31:30Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

providers/tokenbucket/examples_test.go

google-cla · 2021-01-27T17:05:27Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

MalloZup · 2021-01-27T17:06:29Z

@googlebot I consent

google-cla · 2021-01-27T17:06:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

yashrsharma44

Sounds great, some nitpickings!

providers/tokenbucket/limiter.go

providers/tokenbucket/examples_test.go

providers/tokenbucket/doc.go

providers/tokenbucket/examples_test.go

providers/tokenbucket/limiter.go

bwplotka

LGTM after @yashrsharma44 valid comments are addressed.

Thanks @yashrsharma44 for solid review 👍🏽

yashrsharma44 · 2021-01-28T08:40:27Z

@googlebot I consent

MalloZup · 2021-01-28T08:41:13Z

thx @yashrsharma44 and @bwplotka 💟

providers/tokenbucket/examples_test.go

Use tockenbucket provider Signed-off-by: dmaiocchi <sodar@riseup.net>

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

MalloZup · 2021-01-28T18:42:42Z

@bwplotka @yashrsharma44 should be ok now just check it once you have time 🍡

bwplotka

Last nit hopefully! (:

providers/tokenbucket/limiter.go

providers/tokenbucket/examples_test.go

Signed-off-by: dmaiocchi <sodar@riseup.net>

MalloZup · 2021-01-29T11:18:11Z

should be ok. 🤖

MalloZup · 2021-01-29T11:18:40Z

@bwplotka let me know if you wants that I squash/rebase commits.

bwplotka

PERFECTION ❤️

LGTM!

Thanks a lot (:

MalloZup · 2021-01-29T13:45:52Z

thx @bwplotka and @yashrsharma44 for review. YES WE DID IT ! 😁 thx and see you on the next PR :)

yashrsharma44 · 2021-01-29T14:10:18Z

MISSION ACCOMPLISHED!!! 🎉

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/grpc-ecosystem/go-grpc-middleware](https://togithub.com/grpc-ecosystem/go-grpc-middleware) | `v1.4.0` -> `v2.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v1.4.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgrpc-ecosystem%2fgo-grpc-middleware/v1.4.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc-ecosystem/go-grpc-middleware (github.com/grpc-ecosystem/go-grpc-middleware)</summary> ### [`v2.1.0`](https://togithub.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.1.0) [Compare Source](https://togithub.com/grpc-ecosystem/go-grpc-middleware/compare/v2.0.1...v2.1.0) #### What's Changed - Support for subsystem in grpc prometheus counter and histogram metrics by [@rohsaini](https://togithub.com/rohsaini) in [grpc-ecosystem/go-grpc-middleware#643 - doc: update client interceptors chaining example with grpc functions by [@dethi](https://togithub.com/dethi) in [grpc-ecosystem/go-grpc-middleware#669 - adds fields from durationFieldFunc to request/response log entries by [@vroldanbet](https://togithub.com/vroldanbet) in [grpc-ecosystem/go-grpc-middleware#670 - add doc for disabling log opts by [@coleenquadros](https://togithub.com/coleenquadros) in [grpc-ecosystem/go-grpc-middleware#680 - Middleware for determining the real ip of the client by [@MadsRC](https://togithub.com/MadsRC) in [grpc-ecosystem/go-grpc-middleware#682 - protovalidate: add option to ignore certain message types by [@igor-tsiglyar](https://togithub.com/igor-tsiglyar) in [grpc-ecosystem/go-grpc-middleware#684 - Update README.md by [@zeroboo](https://togithub.com/zeroboo) in [grpc-ecosystem/go-grpc-middleware#688 - Fix `InitializeMetrics` signature to allow use with `xds.GRPCServer` by [@bozaro](https://togithub.com/bozaro) in [grpc-ecosystem/go-grpc-middleware#689 - Support retriable func condition by [@tamayika](https://togithub.com/tamayika) in [grpc-ecosystem/go-grpc-middleware#687 - Extend realip parsing of GRPC peer address to handle IPv6 by [@surik](https://togithub.com/surik) in [grpc-ecosystem/go-grpc-middleware#692 - Fix logging Example : log only first field by [@arckadious](https://togithub.com/arckadious) in [grpc-ecosystem/go-grpc-middleware#694 - Extent realip interceptors with ip selection based on proxy count and list by [@surik](https://togithub.com/surik) in [grpc-ecosystem/go-grpc-middleware#695 - Fix for vulnerability CVE-2023-44487 by [@vkaushik](https://togithub.com/vkaushik) in [grpc-ecosystem/go-grpc-middleware#696 #### New Contributors - [@rohsaini](https://togithub.com/rohsaini) made their first contribution in [grpc-ecosystem/go-grpc-middleware#643 - [@dethi](https://togithub.com/dethi) made their first contribution in [grpc-ecosystem/go-grpc-middleware#669 - [@vroldanbet](https://togithub.com/vroldanbet) made their first contribution in [grpc-ecosystem/go-grpc-middleware#670 - [@MadsRC](https://togithub.com/MadsRC) made their first contribution in [grpc-ecosystem/go-grpc-middleware#682 - [@igor-tsiglyar](https://togithub.com/igor-tsiglyar) made their first contribution in [grpc-ecosystem/go-grpc-middleware#684 - [@zeroboo](https://togithub.com/zeroboo) made their first contribution in [grpc-ecosystem/go-grpc-middleware#688 - [@bozaro](https://togithub.com/bozaro) made their first contribution in [grpc-ecosystem/go-grpc-middleware#689 - [@tamayika](https://togithub.com/tamayika) made their first contribution in [grpc-ecosystem/go-grpc-middleware#687 - [@surik](https://togithub.com/surik) made their first contribution in [grpc-ecosystem/go-grpc-middleware#692 - [@arckadious](https://togithub.com/arckadious) made their first contribution in [grpc-ecosystem/go-grpc-middleware#694 - [@vkaushik](https://togithub.com/vkaushik) made their first contribution in [grpc-ecosystem/go-grpc-middleware#696 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v2.0.1...v2.1.0 ### [`v2.0.1`](https://togithub.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.1) [Compare Source](https://togithub.com/grpc-ecosystem/go-grpc-middleware/compare/v2.0.0...v2.0.1) #### What's Changed - Fix outdated 'make proto' command by [@takp](https://togithub.com/takp) in [grpc-ecosystem/go-grpc-middleware#623 - Fix linting errors by [@takp](https://togithub.com/takp) in [grpc-ecosystem/go-grpc-middleware#624 - Logging: Add missing variadic operator for fields by [@olivierlemasle](https://togithub.com/olivierlemasle) in [grpc-ecosystem/go-grpc-middleware#629 - feat: Support extracting fields from CallMeta by [@fsaintjacques](https://togithub.com/fsaintjacques) in [grpc-ecosystem/go-grpc-middleware#628 - Fix "make test" and "make lint" by [@olivierlemasle](https://togithub.com/olivierlemasle) in [grpc-ecosystem/go-grpc-middleware#627 - Do not set timeout for stream initialization by [@DavyJohnes](https://togithub.com/DavyJohnes) in [grpc-ecosystem/go-grpc-middleware#645 - Add logging option to disable fields in log entry by [@coleenquadros](https://togithub.com/coleenquadros) in [grpc-ecosystem/go-grpc-middleware#631 - Update logging adapter docs by [@aboryslawski](https://togithub.com/aboryslawski) in [grpc-ecosystem/go-grpc-middleware#647 #### New Contributors - [@takp](https://togithub.com/takp) made their first contribution in [grpc-ecosystem/go-grpc-middleware#623 - [@olivierlemasle](https://togithub.com/olivierlemasle) made their first contribution in [grpc-ecosystem/go-grpc-middleware#629 - [@fsaintjacques](https://togithub.com/fsaintjacques) made their first contribution in [grpc-ecosystem/go-grpc-middleware#628 - [@DavyJohnes](https://togithub.com/DavyJohnes) made their first contribution in [grpc-ecosystem/go-grpc-middleware#645 - [@coleenquadros](https://togithub.com/coleenquadros) made their first contribution in [grpc-ecosystem/go-grpc-middleware#631 - [@aboryslawski](https://togithub.com/aboryslawski) made their first contribution in [grpc-ecosystem/go-grpc-middleware#647 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v2.0.0...v2.0.1 ### [`v2.0.0`](https://togithub.com/grpc-ecosystem/go-grpc-middleware/releases/tag/v2.0.0) [Compare Source](https://togithub.com/grpc-ecosystem/go-grpc-middleware/compare/v1.4.0...v2.0.0) This is the first stable release of the new v2 release branch 🎉 Many of the interceptors have been rewritten from scratch and the project has been upgraded to use the Go Protobuf v2 API. See the project README for details and migration guide. Thanks to all contributors who made this possible! 💪🏽 #### What's Changed - Initial change for v2. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#276 - Updated README with note that it's under development. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#278 - Fix typo in field extractor (splices -> slices) ([#287](https://togithub.com/grpc-ecosystem/go-grpc-middleware/issues/287)) by [@bvwells](https://togithub.com/bvwells) in [grpc-ecosystem/go-grpc-middleware#289 - Moved imports to v2; Moved to Go 1.14.2 by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#290 - Formatted code; Added goimports to Makefile, Renamed pb_testproto to testpb. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#291 - Fixed providers go modules, examples and consistency. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#292 - added example for AuthFuncOverride v2 branch by [@tegk](https://togithub.com/tegk) in [grpc-ecosystem/go-grpc-middleware#294 - Added some description of the Makefile in the contributing.md by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#298 - v2: Add support for the zerolog logging provider by [@irridia](https://togithub.com/irridia) in [grpc-ecosystem/go-grpc-middleware#299 - proto: fix gogoproto import by [@johanbrandhorst](https://togithub.com/johanbrandhorst) in [grpc-ecosystem/go-grpc-middleware#302 - Retry dial and connection errors for grpc stream. by [@kartlee](https://togithub.com/kartlee) in [grpc-ecosystem/go-grpc-middleware#308 - Moved to GH actions; Added lint; Added issue/PR templates. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#296 - inline localhost certificate into go file by [@bmon](https://togithub.com/bmon) in [grpc-ecosystem/go-grpc-middleware#318 - Update streaming interceptor example by [@G07cha](https://togithub.com/G07cha) in [grpc-ecosystem/go-grpc-middleware#322 - Do not stop retrying based on earlier good message from the stream by [@kartlee](https://togithub.com/kartlee) in [grpc-ecosystem/go-grpc-middleware#323 - test certs - cherry-pick PR325 on v2 by [@dmitris](https://togithub.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#331 - add all make target, reword instructions by [@dmitris](https://togithub.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#335 - remove 1.12.x from build config for consistency with master by [@dmitris](https://togithub.com/dmitris) in [grpc-ecosystem/go-grpc-middleware#337 - \[v2] Fix the special case for jaeger format traceid extraction by [@nvx](https://togithub.com/nvx) in [grpc-ecosystem/go-grpc-middleware#340 - \[v2] Fix ctxtags TagBasedRequestFieldExtractor extracting from fields in a oneof by [@nvx](https://togithub.com/nvx) in [grpc-ecosystem/go-grpc-middleware#339 - Request Logging by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#311 - Bug fix for data race by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#354 - make ratelimit interface context aware by [@xinxiao](https://togithub.com/xinxiao) in [grpc-ecosystem/go-grpc-middleware#367 - Add error param to the decider method of logging middleware by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#372 - \[v2] Add skip interceptor by [@XSAM](https://togithub.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#364 - Chain middleware by [@drewwells](https://togithub.com/drewwells) in [grpc-ecosystem/go-grpc-middleware#385 - Update travis ci badget to Github actions badge. by [@drewwells](https://togithub.com/drewwells) in [grpc-ecosystem/go-grpc-middleware#384 - Upgraded proto related deps: grpc and protobuf; removed gogo from core. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#321 - improve v2 rate-limiter by [@MalloZup](https://togithub.com/MalloZup) in [grpc-ecosystem/go-grpc-middleware#380 - Moved to buf; Added buf lint; Fixed ping service to match standards; … by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#383 - Add timer interface for OpenMetrics(Prometheus) Provider by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#387 - \[Rate-limit provider]: Add token bucket implementation of rate-limiter by [@MalloZup](https://togithub.com/MalloZup) in [grpc-ecosystem/go-grpc-middleware#386 - Add OpenMetrics(Prometheus) in the provider module by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#379 - v2: Client unary interceptor timeout on v2 branch by [@instabledesign](https://togithub.com/instabledesign) in [grpc-ecosystem/go-grpc-middleware#330 - add onRetryCallback callback function by [@shamil](https://togithub.com/shamil) in [grpc-ecosystem/go-grpc-middleware#405 - v2: validator support for protoc-gen-validate 0.6.0 by [@danielhochman](https://togithub.com/danielhochman) in [grpc-ecosystem/go-grpc-middleware#418 - v2: Refactor metrics interceptor and fix tests by [@ash2k](https://togithub.com/ash2k) in [grpc-ecosystem/go-grpc-middleware#413 - Support customization of timestamp format (v2 branch) by [@stanhu](https://togithub.com/stanhu) in [grpc-ecosystem/go-grpc-middleware#399 - Fixed misleading comments in the interceptor file by [@iamrajiv](https://togithub.com/iamrajiv) in [grpc-ecosystem/go-grpc-middleware#424 - v2: Switch from github.com/go-kit/kit to github.com/go-kit/log interfaces by [@liggitt](https://togithub.com/liggitt) in [grpc-ecosystem/go-grpc-middleware#427 - v2: Add support for the phuslog logging provider by [@ogimenezb](https://togithub.com/ogimenezb) in [grpc-ecosystem/go-grpc-middleware#425 - v2:providers/zap: fix caller annotation by [@jkawamoto](https://togithub.com/jkawamoto) in [grpc-ecosystem/go-grpc-middleware#432 - Added Dependabot by [@iamrajiv](https://togithub.com/iamrajiv) in [grpc-ecosystem/go-grpc-middleware#376 - Added a Copyright check in the Makefile by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#420 - Cleanup v2 with some updates by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#419 - openmetrics: forward server context by [@amenzhinsky](https://togithub.com/amenzhinsky) in [grpc-ecosystem/go-grpc-middleware#434 - recovery: change the default behavior by [@amenzhinsky](https://togithub.com/amenzhinsky) in [grpc-ecosystem/go-grpc-middleware#439 - Add all-validator support by [@leventeliu](https://togithub.com/leventeliu) in [grpc-ecosystem/go-grpc-middleware#443 - Remove backoffutils and added the files to retry package by [@yashrsharma44](https://togithub.com/yashrsharma44) in [grpc-ecosystem/go-grpc-middleware#390 - v2:interceptors/logging: allow to separate request response payload logging by [@michaljemala](https://togithub.com/michaljemala) in [grpc-ecosystem/go-grpc-middleware#442 - Removed tags; Simplified interceptor code; Added logging fields editability. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#394 - InterceptorTestSuite client connection optimize by [@HUSTtoKTH](https://togithub.com/HUSTtoKTH) in [grpc-ecosystem/go-grpc-middleware#455 - Remove opentracing from go.mod by [@jpkrohling](https://togithub.com/jpkrohling) in [grpc-ecosystem/go-grpc-middleware#477 - Replace two old Go versions with two new ones by [@jpkrohling](https://togithub.com/jpkrohling) in [grpc-ecosystem/go-grpc-middleware#478 - Move util/metautils to root-level package metadata, fixes [#392](https://togithub.com/grpc-ecosystem/go-grpc-middleware/issues/392) by [@rahulkhairwar](https://togithub.com/rahulkhairwar) in [grpc-ecosystem/go-grpc-middleware#474 - Remove data race from zerolog provider by [@ecordell](https://togithub.com/ecordell) in [grpc-ecosystem/go-grpc-middleware#487 - Update provider/kit by [@metalmatze](https://togithub.com/metalmatze) in [grpc-ecosystem/go-grpc-middleware#490 - Refactor tracing interceptor by [@XSAM](https://togithub.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#450 - Add opentracing provider by [@XSAM](https://togithub.com/XSAM) in [grpc-ecosystem/go-grpc-middleware#492 - update phuslog to fix typo by [@ogimenezb](https://togithub.com/ogimenezb) in [grpc-ecosystem/go-grpc-middleware#499 - Added logr as logging Library provider by [@mcdoker18](https://togithub.com/mcdoker18) in [grpc-ecosystem/go-grpc-middleware#510 - ✨ new feat: selector middleware by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#511 - Add 1.18.x and 1.19.x unit tests by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#513 - change the doc.go to the latest format by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#512 - fix provider examples by [@forsaken628](https://togithub.com/forsaken628) in [grpc-ecosystem/go-grpc-middleware#529 - docs: add `logging.InjectFields` usage description by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#541 - Bump golang.org/x/net from 0.0.0-20201021035429-f5854403a974 to 0.7.0 by [@dependabot](https://togithub.com/dependabot) in [grpc-ecosystem/go-grpc-middleware#537 - v2: All for v2: Exemplars, Cleanup, Docs, Lint, Proto upgrades and more by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#543 - \[interceptors/validator] feat: add error logging in validator by [@rohanraj7316](https://togithub.com/rohanraj7316) in [grpc-ecosystem/go-grpc-middleware#544 - fix auto-generated docs by [@peczenyj](https://togithub.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#548 - fix vulnerability GO-2022-0603 by [@peczenyj](https://togithub.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#549 - add support to trace on grpc_logrus.DefaultMessageProducer by [@peczenyj](https://togithub.com/peczenyj) in [grpc-ecosystem/go-grpc-middleware#547 - Simplified logging middleware; Fields are now "any" type; Moved logging providers to examples only. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#552 - Removed deciders; Cleaned up validators. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#554 - Adjustments to README and consistency of callback options. by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#555 - Merge v2 into main (with -X theirs) by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#556 - Bump golang.org/x/net from 0.5.0 to 0.7.0 in /providers/prometheus by [@dependabot](https://togithub.com/dependabot) in [grpc-ecosystem/go-grpc-middleware#561 - Fix overwritten logger in zerolog example by [@longshine](https://togithub.com/longshine) in [grpc-ecosystem/go-grpc-middleware#574 - Changed for for mapping fields, different var for logger in zap example by [@MichalFikejs](https://togithub.com/MichalFikejs) in [grpc-ecosystem/go-grpc-middleware#581 - cleanup: no cap definition required by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#582 - providers/prometheus: Add WithHistogramOpts for native histograms by [@metalmatze](https://togithub.com/metalmatze) in [grpc-ecosystem/go-grpc-middleware#584 - fix: Refactor logger initialization in example_test.go by [@aimuz](https://togithub.com/aimuz) in [grpc-ecosystem/go-grpc-middleware#580 - Minor code cleanups by [@ash2k](https://togithub.com/ash2k) in [grpc-ecosystem/go-grpc-middleware#586 - fix prometheus interceptors not converting context errors to gRPC codes by [@vtermanis](https://togithub.com/vtermanis) in [grpc-ecosystem/go-grpc-middleware#571 - Update README.md by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#600 - Update PULL_REQUEST_TEMPLATE.md by [@bwplotka](https://togithub.com/bwplotka) in [grpc-ecosystem/go-grpc-middleware#601 - Add Client rate limit interceptors 520 by [@rahulkhairwar](https://togithub.com/rahulkhairwar) in [grpc-ecosystem/go-grpc-middleware#599 - Use default go errors package instead of github.com/pkg/errors by [@rifkyazizf](https://togithub.com/rifkyazizf) in [grpc-ecosystem/go-grpc-middleware#608 - fix bug : should drain channel of timer after stop by [@ikenchina](https://togithub.com/ikenchina) in [grpc-ecosystem/go-grpc-middleware#612 - feat: add interceptor for bufbuild/protovalidate by [@gvencadze](https://togithub.com/gvencadze) in [grpc-ecosystem/go-grpc-middleware#614 - Enhancement: Introduce Option Interface for Future Interceptor Customization by [@elliotmjackson](https://togithub.com/elliotmjackson) in [grpc-ecosystem/go-grpc-middleware#615 #### New Contributors - [@irridia](https://togithub.com/irridia) made their first contribution in [grpc-ecosystem/go-grpc-middleware#299 - [@xinxiao](https://togithub.com/xinxiao) made their first contribution in [grpc-ecosystem/go-grpc-middleware#367 - [@XSAM](https://togithub.com/XSAM) made their first contribution in [grpc-ecosystem/go-grpc-middleware#364 - [@MalloZup](https://togithub.com/MalloZup) made their first contribution in [grpc-ecosystem/go-grpc-middleware#380 - [@instabledesign](https://togithub.com/instabledesign) made their first contribution in [grpc-ecosystem/go-grpc-middleware#330 - [@shamil](https://togithub.com/shamil) made their first contribution in [grpc-ecosystem/go-grpc-middleware#405 - [@ash2k](https://togithub.com/ash2k) made their first contribution in [grpc-ecosystem/go-grpc-middleware#413 - [@ogimenezb](https://togithub.com/ogimenezb) made their first contribution in [grpc-ecosystem/go-grpc-middleware#425 - [@amenzhinsky](https://togithub.com/amenzhinsky) made their first contribution in [grpc-ecosystem/go-grpc-middleware#434 - [@leventeliu](https://togithub.com/leventeliu) made their first contribution in [grpc-ecosystem/go-grpc-middleware#443 - [@michaljemala](https://togithub.com/michaljemala) made their first contribution in [grpc-ecosystem/go-grpc-middleware#442 - [@HUSTtoKTH](https://togithub.com/HUSTtoKTH) made their first contribution in [grpc-ecosystem/go-grpc-middleware#455 - [@jpkrohling](https://togithub.com/jpkrohling) made their first contribution in [grpc-ecosystem/go-grpc-middleware#477 - [@rahulkhairwar](https://togithub.com/rahulkhairwar) made their first contribution in [grpc-ecosystem/go-grpc-middleware#474 - [@ecordell](https://togithub.com/ecordell) made their first contribution in [grpc-ecosystem/go-grpc-middleware#487 - [@metalmatze](https://togithub.com/metalmatze) made their first contribution in [grpc-ecosystem/go-grpc-middleware#490 - [@mcdoker18](https://togithub.com/mcdoker18) made their first contribution in [grpc-ecosystem/go-grpc-middleware#510 - [@aimuz](https://togithub.com/aimuz) made their first contribution in [grpc-ecosystem/go-grpc-middleware#511 - [@forsaken628](https://togithub.com/forsaken628) made their first contribution in [grpc-ecosystem/go-grpc-middleware#529 - [@dependabot](https://togithub.com/dependabot) made their first contribution in [grpc-ecosystem/go-grpc-middleware#537 - [@rohanraj7316](https://togithub.com/rohanraj7316) made their first contribution in [grpc-ecosystem/go-grpc-middleware#544 - [@peczenyj](https://togithub.com/peczenyj) made their first contribution in [grpc-ecosystem/go-grpc-middleware#548 - [@longshine](https://togithub.com/longshine) made their first contribution in [grpc-ecosystem/go-grpc-middleware#574 - [@MichalFikejs](https://togithub.com/MichalFikejs) made their first contribution in [grpc-ecosystem/go-grpc-middleware#581 - [@vtermanis](https://togithub.com/vtermanis) made their first contribution in [grpc-ecosystem/go-grpc-middleware#571 - [@rifkyazizf](https://togithub.com/rifkyazizf) made their first contribution in [grpc-ecosystem/go-grpc-middleware#608 - [@ikenchina](https://togithub.com/ikenchina) made their first contribution in [grpc-ecosystem/go-grpc-middleware#612 - [@gvencadze](https://togithub.com/gvencadze) made their first contribution in [grpc-ecosystem/go-grpc-middleware#614 - [@elliotmjackson](https://togithub.com/elliotmjackson) made their first contribution in [grpc-ecosystem/go-grpc-middleware#615 **Full Changelog**: grpc-ecosystem/go-grpc-middleware@v1.4.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaegertracing/jaeger).  --------- Signed-off-by: Mend Renovate <bot@renovateapp.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Yuri Shkuro <github@ysh.us>

MalloZup changed the title ~~WIP: [Rate-limit provider]: Add tocken bucket implementation of rate-limiter~~ [Rate-limit provider]: Add tocken bucket implementation of rate-limiter Jan 23, 2021

bwplotka reviewed Jan 23, 2021

View reviewed changes

providers/tokenbucket/doc.go Outdated Show resolved Hide resolved

providers/tokenbucket/examples_test.go Outdated Show resolved Hide resolved

providers/tokenbucket/go.mod Outdated Show resolved Hide resolved

providers/tokenbucket/limiter.go Outdated Show resolved Hide resolved

MalloZup force-pushed the rate-limit-provider branch from 7abb989 to bb1cfa9 Compare January 25, 2021 11:31

bwplotka reviewed Jan 25, 2021

View reviewed changes

providers/tokenbucket/examples_test.go Outdated Show resolved Hide resolved

MalloZup force-pushed the rate-limit-provider branch from bb1cfa9 to df0eb12 Compare January 27, 2021 17:05

MalloZup force-pushed the rate-limit-provider branch from df0eb12 to 36d7d4f Compare January 27, 2021 17:09

MalloZup requested review from bwplotka and yashrsharma44 January 27, 2021 17:11

yashrsharma44 reviewed Jan 27, 2021

View reviewed changes

bwplotka approved these changes Jan 27, 2021

View reviewed changes

bwplotka reviewed Jan 28, 2021

View reviewed changes

providers/tokenbucket/examples_test.go Outdated Show resolved Hide resolved

MalloZup and others added 8 commits January 28, 2021 12:53

Add tocken bucket implementation of rate-limiter

224625a

Use tockenbucket provider Signed-off-by: dmaiocchi <sodar@riseup.net>

Update providers/tokenbucket/limiter.go

96640c0

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/examples_test.go

f8fc1cb

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/limiter.go

f34fce1

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/limiter.go

e58896c

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/doc.go

31d82c9

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/limiter.go

5f5036d

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

Update providers/tokenbucket/examples_test.go

2e2db6f

Co-authored-by: Yash Sharma <yashrsharma44@gmail.com>

MalloZup force-pushed the rate-limit-provider branch from 29a94a5 to 6046c8b Compare January 28, 2021 11:55

MalloZup requested a review from bwplotka January 28, 2021 12:03

MalloZup requested a review from yashrsharma44 January 28, 2021 12:03

bwplotka changed the title ~~[Rate-limit provider]: Add tocken bucket implementation of rate-limiter~~ [Rate-limit provider]: Add token bucket implementation of rate-limiter Jan 28, 2021

bwplotka reviewed Jan 28, 2021

View reviewed changes

providers/tokenbucket/limiter.go Outdated Show resolved Hide resolved

providers/tokenbucket/examples_test.go Outdated Show resolved Hide resolved

Fix word and minor changes

733f36f

Signed-off-by: dmaiocchi <sodar@riseup.net>

MalloZup force-pushed the rate-limit-provider branch from 0bb8795 to 733f36f Compare January 29, 2021 10:15

bwplotka approved these changes Jan 29, 2021

View reviewed changes

bwplotka merged commit 20b2825 into grpc-ecosystem:v2 Jan 29, 2021

yashrsharma44 mentioned this pull request Jan 30, 2021

Enhance dummy rate limit interceptor we have. #351

Closed

yashrsharma44 mentioned this pull request Jul 14, 2021

Refactor tracing implements #312

Closed

aimuz mentioned this pull request Mar 8, 2023

docs: add logging.InjectFields usage description #540

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rate-limit provider]: Add token bucket implementation of rate-limiter #386

[Rate-limit provider]: Add token bucket implementation of rate-limiter #386

MalloZup commented Jan 23, 2021 •

edited

Loading

codecov-io commented Jan 23, 2021 •

edited

Loading

MalloZup commented Jan 23, 2021

bwplotka left a comment

MalloZup commented Jan 23, 2021

google-cla bot commented Jan 25, 2021

google-cla bot commented Jan 27, 2021

MalloZup commented Jan 27, 2021

google-cla bot commented Jan 27, 2021

yashrsharma44 left a comment

bwplotka left a comment

yashrsharma44 commented Jan 28, 2021

MalloZup commented Jan 28, 2021

MalloZup commented Jan 28, 2021

bwplotka left a comment

MalloZup commented Jan 29, 2021

MalloZup commented Jan 29, 2021

bwplotka left a comment

MalloZup commented Jan 29, 2021

yashrsharma44 commented Jan 29, 2021

[Rate-limit provider]: Add token bucket implementation of rate-limiter #386

[Rate-limit provider]: Add token bucket implementation of rate-limiter #386

Conversation

MalloZup commented Jan 23, 2021 • edited Loading

codecov-io commented Jan 23, 2021 • edited Loading

Codecov Report

MalloZup commented Jan 23, 2021

bwplotka left a comment

Choose a reason for hiding this comment

MalloZup commented Jan 23, 2021

google-cla bot commented Jan 25, 2021

google-cla bot commented Jan 27, 2021

MalloZup commented Jan 27, 2021

google-cla bot commented Jan 27, 2021

yashrsharma44 left a comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

yashrsharma44 commented Jan 28, 2021

MalloZup commented Jan 28, 2021

MalloZup commented Jan 28, 2021

bwplotka left a comment

Choose a reason for hiding this comment

MalloZup commented Jan 29, 2021

MalloZup commented Jan 29, 2021

bwplotka left a comment

Choose a reason for hiding this comment

MalloZup commented Jan 29, 2021

yashrsharma44 commented Jan 29, 2021

MalloZup commented Jan 23, 2021 •

edited

Loading

codecov-io commented Jan 23, 2021 •

edited

Loading