Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong example misguide user to catch panic #414

Merged

Conversation

Wander1024
Copy link
Contributor

Signed-off-by: wander1024 yawhua1024@gmail.com

recovery should be placed the first.

#410
#215

Signed-off-by: wander1024 <yawhua1024@gmail.com>
@google-cla
Copy link

google-cla bot commented Apr 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #414 (f2c1139) into master (315ddd9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files          42       42           
  Lines        1357     1357           
=======================================
  Hits         1008     1008           
  Misses        295      295           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315ddd9...f2c1139. Read the comment docs.

@Wander1024
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution :). Sorry for the confusion here.

@ivanovaleksey
Copy link

ivanovaleksey commented May 22, 2021

With grpc_recovery in the first place I can see nothing in logger just this

srv := grpc.NewServer(grpc.UnaryInterceptor(
	grpc_middleware.ChainUnaryServer(
		grpc_recovery.UnaryServerInterceptor(),
		grpc_ctxtags.UnaryServerInterceptor(),
		grpc_zap.UnaryServerInterceptor(zapLogger),
	),
))

zap/grpclogger.go:92    [transport]transport: loopyWriter.run returning. connection error: desc = "transport is closing"        {"system": "grpc", "grpc_log": true}

How is it supposed to log a panic occurred?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants