Call retry callback on retry #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Mar 13, 2024
|
NP, Thanks for reviewing! I've added a test for checking that the callback doesn't run for non retriable errors, is there anything else you wound want me to add a case for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Call the on retry callback on retry rather than on failure.
Fixes #699
This will change so that the callback will only be called when retrying, and never with attempt = 0 (because the first attempt is not a retry). Previously it was called when any attempt failed, even if there where no retries.
Verification
I have tested this patch in our local environment where I've performed a load test to provoke some retries, and it now get triggered as I would expect, only on retries.