Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix providers/prometheus depend on go-grpc-middleware v2.1.0 #706

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix providers/prometheus depend on go-grpc-middleware v2.1.0 #706

merged 1 commit into from
Apr 25, 2024

Conversation

marefr
Copy link
Contributor

@marefr marefr commented Apr 24, 2024 •
edited
Loading

Changes

  • Make providers/prometheus depend on go-grpc-middleware v2.1.0 instead of v2.0.0-rc3
  • Got an error when running tests of outdated go modules in examples so ran go mod tidy there as well.

Fixes #705

Verification

I ran the tests.

@marefr marefr mentioned this pull request Apr 24, 2024
Closed
@johanbrandhorst johanbrandhorst merged commit 7da22cf into grpc-ecosystem:main Apr 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

providers/prometheus v1.0.0 dependent on go-grpc-middleware v2.0.0-rc.3
2 participants
@marefr @johanbrandhorst