Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new naming convention for go_library targets #2134

Merged
merged 1 commit into from
May 7, 2021
Merged

Support new naming convention for go_library targets #2134

merged 1 commit into from
May 7, 2021

Conversation

tanyabouman
Copy link
Contributor

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

By default, Gazelle now uses the last component of the Bazel package, rather than go_default_library as the go_library name.

This causes problems when the naming conventions do not match.
bazel-contrib/bazel-gazelle#980
bazel-contrib/bazel-gazelle#890

Adding support for the new naming convention should not break anything that depends on using the old naming convention, because the Gazelle option import_alias makes aliases to the libraries and this allows the old naming convention to still work.

@google-cla google-cla bot added the cla: yes label May 7, 2021
@achew22
Copy link
Collaborator

achew22 commented May 7, 2021

Good fixup! Thanks for the change

@achew22 achew22 merged commit 317b2dc into grpc-ecosystem:master May 7, 2021
@tanyabouman tanyabouman deleted the import-naming-convention branch May 11, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants