Support new naming convention for go_library targets #2134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Yes
Brief description of what is fixed or changed
By default, Gazelle now uses the last component of the Bazel package, rather than
go_default_library
as thego_library name
.This causes problems when the naming conventions do not match.
bazel-contrib/bazel-gazelle#980
bazel-contrib/bazel-gazelle#890
Adding support for the new naming convention should not break anything that depends on using the old naming convention, because the Gazelle option
import_alias
makes aliases to the libraries and this allows the old naming convention to still work.