Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the swagger request body properly #247

Merged
merged 2 commits into from
Nov 5, 2016
Merged

Render the swagger request body properly #247

merged 2 commits into from
Nov 5, 2016

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Nov 3, 2016

The rendering of the http body was always the methods request type.

This is only correct if the body is "*" which is not always true.

@tmc
Copy link
Collaborator

tmc commented Nov 4, 2016

@dprotaso thank you for your contribution -- could you look at the test failure and sign the cla?

@dprotaso
Copy link
Contributor Author

dprotaso commented Nov 4, 2016

Take a look at the failure it's unrelated to the diff. Something in
examples is importing a package that's main.
On Thu, Nov 3, 2016 at 20:28 Travis Cline notifications@github.com wrote:

@dprotaso https://github.com/dprotaso thank you for your contribution
-- could you look at the test failure and sign the cla?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#247 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABIgj_7VJBWyfHiTvKTp4a6cif5t0yyks5q6nwtgaJpZM4Kobpn
.

@dprotaso
Copy link
Contributor Author

dprotaso commented Nov 5, 2016

I rebased but gotip is so fragile - it's failing to fetch and install golint

@tmc
Copy link
Collaborator

tmc commented Nov 5, 2016

@dprotaso I re-ran the tests and the flakiness is solved.

@tmc tmc merged commit 84398b9 into grpc-ecosystem:master Nov 5, 2016
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Render the swagger request body properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants