Make grpc-gateway support enum fields in path parameter #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, could you please show this behavior in a test case? Also please be mindful of unrelated changes in diffs (there's some whitespace noise). Also please sign the CLA. |
…m fields are also supported.
|
Done the code changes. I think I've already signed the CLA: It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below. Not sure what to do next. Thanks! |
|
@tmc This looks like it's good to go for me. Do you object to it? |
|
@achew22 LGTM |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Make grpc-gateway support enum fields in path parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated enum fields are also supported.