Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-openapiv2: Use json_name when generating required field names #2885

Merged
merged 4 commits into from
Sep 14, 2022
Merged

protoc-gen-openapiv2: Use json_name when generating required field names #2885

merged 4 commits into from
Sep 14, 2022

Commits on Sep 12, 2022

  1. protoc-gen-openapiv2: Use json_name when generating required field names 

    Fix the bug from grpc-ecosystem#2874 where the required fields section in the JSON schema would contain autogenerated field names, even when fields had a custom json_name value set. These would then not match up with the actual fields defined in the schema, resulting in an invalid OpenAPI spec.
    @patrick246
    patrick246 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    a64f532 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Reformat protobuf

    @patrick246
    patrick246 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    844b6c1 View commit details
    Browse the repository at this point in the history

  2. Fix failing test

    @patrick246
    patrick246 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    957daf9 View commit details
    Browse the repository at this point in the history

  3. Replace unclear condition when checking required query params 

    Regenerate files, fix formatting
    @patrick246
    patrick246 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b963f20 View commit details
    Browse the repository at this point in the history