chore: use standard httpMethod in generated code #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
commented
Nov 20, 2024
Comment on lines
+330
to
+332
| "toHTTPMethod": func(method string) string { | ||
| return httpMethods[method] | ||
| }, |
There was a problem hiding this comment.
@johanbrandhorst,
I was wondering if this deserves a dedicated package as "github.com/grpc-ecosystem/grpc-gateway/v2/internal/casing" is with for example "github.com/grpc-ecosystem/grpc-gateway/v2/internal/mapping", what do you think ?
There was a problem hiding this comment.
Nah this is fine as it is.
mmorel-35
force-pushed
the
template/httpMethod
branch
from
3178220 to
a291ab5
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
template/httpMethod
branch
from
a291ab5 to
e10a769
Compare
johanbrandhorst
approved these changes
Nov 21, 2024
Comment on lines
+330
to
+332
| "toHTTPMethod": func(method string) string { | ||
| return httpMethods[method] | ||
| }, |
There was a problem hiding this comment.
Nah this is fine as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses standard httpMethod in generated code instead of their quoted raw value.