-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make support paths option #711
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@googlebot I signed it! |
CLAs look good, thanks! |
Hi @izumin5210, this looks like a great addition! I'm a little bit confused by the build error, looks like the files need to be regenerated, but I don't think your change as anything to do with it. Could you update the commit message to contain the same kind of description that your pull request does please? |
@johanbrandhorst I fixed the message! 😄 |
@johanbrandhorst Very strange. We used to have this kind of problem all the time. It was from proto-go being upgraded and changing the output format. When there are no env variables set, we compare the compiled versions of the However, with the submission of #696, I wouldn't expect that to happen any more. I don't know a lot about dep unfortunately. I was hoping we could just wait till vgo, but I'm glad we did this. Looking at this line is it possible that we are overriding our go dep and explicitly installing the HEAD version of proto-go? The other two failures appear to just be standard tooling errors. If we paid for Travis I bet it would be more stable, but the free version is kind of flaky. I re-triggered them and they passed. |
That line is only installing golint, it shouldn't affect the version of |
@johanbrandhorst, I wasn't meaning to imply that line specifically, but is there something in that file you would expect is updating our dependencies to head instead of the vendored versions? |
No, I cant see how it would do that. I agree I figured itd be fixed by the dependency locking. I guess we'll have to do some more digging. |
I fixed it by manually applying the patch. Could you please rebase this PR to see how Travis feels about it now? Thanks! |
Make protoc-gen-grpc-gateway support paths option such like golang/protobuf#515.
I rebased! But CI failed again 😢
https://travis-ci.org/grpc-ecosystem/grpc-gateway/jobs/411080943#L557-L561 |
Looks like it's all working again, thanks for your contribution! |
Make
protoc-gen-grpc-gateway
supportpaths
option such like golang/protobuf#515