Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to make Travis Green #17

Merged
merged 4 commits into from
Jun 29, 2017
Merged

Fixes to make Travis Green #17

merged 4 commits into from
Jun 29, 2017

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jun 29, 2017

No description provided.

Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Any idea how we can get analyzer coverage on the examples, too? They need their own pubspec's, which I guess is where this problem comes from.

@kevmoo
Copy link
Contributor Author

kevmoo commented Jun 29, 2017

Any idea how we can get analyzer coverage on the examples, too? They need their own pubspec's, which I guess is where this problem comes from.

Sadly, no.

Not as long as we're using the dart_task thing.

We'd have to go back to using travis.sh so we can run tasks within a sub directory

@kevmoo
Copy link
Contributor Author

kevmoo commented Jun 29, 2017

...or create a test in root/test that runs the analyzer process on the subdirectory – a bit of a hack, but it'd work

@jakobr-google
Copy link
Contributor

I think I'll just add a custom step to analyze the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants