Improve BalancerAttributes debugging (#2235)

grpc · Aug 7, 2023 · d305ee4 · d305ee4
1 parent 19e059f
commit d305ee4
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/src/Grpc.Net.Client/Balancer/BalancerAttributes.cs b/src/Grpc.Net.Client/Balancer/BalancerAttributes.cs
@@ -20,6 +20,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 
 namespace Grpc.Net.Client.Balancer;
@@ -30,6 +31,8 @@ namespace Grpc.Net.Client.Balancer;
 /// Note: Experimental API that can change or be removed without any prior notice.
 /// </para>
 /// </summary>
+[DebuggerDisplay("{DebuggerToString(),nq}")]
+[DebuggerTypeProxy(typeof(BalancerAttributesDebugView))]
 public sealed class BalancerAttributes : IDictionary<string, object?>, IReadOnlyDictionary<string, object?>
 {
     /// <summary>
@@ -134,5 +137,23 @@ public bool Remove<TValue>(BalancerAttributesKey<TValue> key)
     {
         return _attributes.Remove(key.Key);
     }
+
+    internal string DebuggerToString()
+    {
+        return $"Count = {_attributes.Count}";
+    }
+
+    private sealed class BalancerAttributesDebugView
+    {
+        private readonly BalancerAttributes _collection;
+
+        public BalancerAttributesDebugView(BalancerAttributes collection)
+        {
+            _collection = collection;
+        }
+
+        [DebuggerBrowsable(DebuggerBrowsableState.RootHidden)]
+        public KeyValuePair<string, object?>[] Items => _collection.Select(pair => new KeyValuePair<string, object?>(pair.Key, pair.Value)).ToArray();
+    }
 }
 #endif