Skip to content

cherry-pick #7523 to v1.66.x branch #11558

cherry-pick #7523 to v1.66.x branch

cherry-pick #7523 to v1.66.x branch #11558

Triggered via pull request August 21, 2024 23:12
Status Failure
Total duration 5m 41s
Artifacts

testing.yml

on: pull_request
vet-proto
25s
vet-proto
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

11 errors
tests (vet, 1.22): cmd/protoc-gen-go-grpc/grpc.go#L352
if block ends with a return statement, so drop this else and outdent its block https://revive.run/r#indent-error-flow
tests (vet, 1.22): cmd/protoc-gen-go-grpc/grpc.go#L519
if block ends with a return statement, so drop this else and outdent its block https://revive.run/r#indent-error-flow
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L57
exported method MetricsRecorderList.RecordInt64Count should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L65
exported method MetricsRecorderList.RecordFloat64Count should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L73
exported method MetricsRecorderList.RecordInt64Histo should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L81
exported method MetricsRecorderList.RecordFloat64Histo should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L89
exported method MetricsRecorderList.RecordInt64Gauge should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L382
context.Context should be the first parameter of a function https://revive.run/r#context-as-argument
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L34
don't use an underscore in package name https://revive.run/r#var-naming
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L56
don't use underscores in Go names; type SearchResponseV3_State should be SearchResponseV3State https://revive.run/r#var-naming
tests (tests, 1.22, arm64)
Process completed with exit code 1.