Skip to content

Commit

Permalink
xds: Surround two Infof calls that use pretty.ToJSON with V(2)
Browse files Browse the repository at this point in the history
…checks (#7216)
  • Loading branch information
townba authored May 9, 2024
1 parent 2dbbcef commit 6b413c8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion xds/internal/balancer/clusterimpl/clusterimpl.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ func (b *clusterImplBalancer) UpdateClientConnState(s balancer.ClientConnState)
return nil
}

b.logger.Infof("Received update from resolver, balancer config: %+v", pretty.ToJSON(s.BalancerConfig))
if b.logger.V(2) {
b.logger.Infof("Received update from resolver, balancer config: %s", pretty.ToJSON(s.BalancerConfig))
}
newConfig, ok := s.BalancerConfig.(*LBConfig)
if !ok {
return fmt.Errorf("unexpected balancer config with type: %T", s.BalancerConfig)
Expand Down
4 changes: 3 additions & 1 deletion xds/internal/balancer/clusterresolver/clusterresolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,9 @@ func (b *clusterResolverBalancer) updateChildConfig() {
b.logger.Warningf("Failed to parse child policy config. This should never happen because the config was generated: %v", err)
return
}
b.logger.Infof("Built child policy config: %v", pretty.ToJSON(childCfg))
if b.logger.V(2) {
b.logger.Infof("Built child policy config: %s", pretty.ToJSON(childCfg))
}

endpoints := make([]resolver.Endpoint, len(addrs))
for i, a := range addrs {
Expand Down

0 comments on commit 6b413c8

Please sign in to comment.