Skip to content

Commit

Permalink
ignore credentials/google package as this package doesnt have default…
Browse files Browse the repository at this point in the history
… timeout defined
  • Loading branch information
hasson82 committed Jun 19, 2024
1 parent d595842 commit a1e7035
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/vet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ git grep 'func (s) ' -- "*_test.go" | not grep -v 'func (s) Test'
git grep 'func [A-Z]' -- "*_test.go" | not grep -v 'func Test\|Benchmark\|Example'

# - Make sure all context usages are done timeout.
git grep -e 'context.Background()' --or -e 'context.TODO()' -- "*_test.go" | grep -v "benchmark/primitives/context_test.go" | not grep -v 'context.WithTimeout(context.Background()' | not grep -v 'context.WithTimeOut(context.TODO()'
git grep -e 'context.Background()' --or -e 'context.TODO()' -- "*_test.go" | grep -v "benchmark/primitives/context_test.go" | grep -v "credentials/google" | not grep -v 'context.WithTimeout(context.Background()' | not grep -v 'context.WithTimeOut(context.TODO()'

# - Do not use time.After except in tests. It has the potential to leak the
# timer since there is no way to stop it early.
Expand Down

0 comments on commit a1e7035

Please sign in to comment.