Skip to content

Commit

Permalink
change lint rule to not to enforce that the grep returns nothing
Browse files Browse the repository at this point in the history
  • Loading branch information
hasson82 committed Jun 20, 2024
1 parent 689ae5b commit c29c45c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/vet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ not git grep "\(import \|^\s*\)\"google.golang.org/grpc/interop/grpc_testing" --
git grep '"github.com/envoyproxy/go-control-plane/envoy' -- '*.go' ':(exclude)*.pb.go' | not grep -v 'pb "\|grpc "'

# - Ensure all context usages are done with timeout.
git grep -e 'context.Background()' --or -e 'context.TODO()' -- "*_test.go" | not grep -v "benchmark/primitives/context_test.go" | not grep -v "credentials/google" | not grep -v "internal/transport/" | not grep -v "xds/internal/" | not grep -v "security/advancedtls" | not grep -v 'context.WithTimeout(' | not grep -v 'context.WithCancel('

git grep -e 'context.Background()' --or -e 'context.TODO()' -- "*_test.go" | grep -v "benchmark/primitives/context_test.go" | grep -v "credential
s/google" | grep -v "internal/transport/" | grep -v "xds/internal/" | grep -v "security/advancedtls" | grep -v 'context.WithTimeout(' | not grep -v 'context.WithCancel('

misspell -error .

Expand Down

0 comments on commit c29c45c

Please sign in to comment.