Skip to content

Commit

Permalink
security/advancedtls: fix test that relies on min TLS version
Browse files Browse the repository at this point in the history
Go 1.22 changed the default TLS minimum version. Toolchains which do not
respect go.mod 'go' version directives will break when executing the
Test/GetCertificatesSNI/Select_serverCert3 test, since it relies on the
private tls.ClientHelloInfo.config fields minimum version matching the
configured tls.ClientHelloInfo.SupportedVersions field. This change just
bumps the version in tls.ClientHelloInfo.SupportedVersions to
tls.VersionTLS12.

This fixes an internal google test.
  • Loading branch information
rolandshoemaker committed Nov 29, 2023
1 parent 737f87b commit d29c20d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion security/advancedtls/advancedtls_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@ func (s) TestGetCertificatesSNI(t *testing.T) {
ServerName: test.serverName,
SupportedCurves: []tls.CurveID{tls.CurveP256},
SupportedPoints: []uint8{pointFormatUncompressed},
SupportedVersions: []uint16{tls.VersionTLS10},
SupportedVersions: []uint16{tls.VersionTLS12},
}
gotCertificate, err := serverConfig.GetCertificate(clientHello)
if err != nil {
Expand Down

0 comments on commit d29c20d

Please sign in to comment.