Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: with TLS, TCP user timeout is not set on the underlying connection #5646

Closed
costinm opened this issue Sep 8, 2022 · 5 comments · Fixed by #6321
Closed

server: with TLS, TCP user timeout is not set on the underlying connection #5646

costinm opened this issue Sep 8, 2022 · 5 comments · Fixed by #6321

Comments

@costinm
Copy link

costinm commented Sep 8, 2022

if err = syscall.SetTCPUserTimeout(conn, kp.Timeout); err != nil {

I was looking at the write code - for net.Conn this works as expected, but if TLS is used conn will be tls.Conn so the line will
not set a timeout. I would guess rawconn should be passed ?

@easwars easwars assigned dfawley and unassigned zasweq Oct 18, 2022
@dfawley dfawley removed their assignment Oct 18, 2022
@dfawley
Copy link
Member

dfawley commented Oct 18, 2022

Unassigning; I thought this was client-side, but it looks like the client is done correctly and only the server needs to be fixed. I probably don't have cycles for this right now.

@dfawley dfawley changed the title Likely bug - if TLS is used timeout not set server: with TLS, TCP user timeout is not set on the underlying connection Oct 18, 2022
@zasweq zasweq added the fixit label Nov 28, 2022
@tobotg
Copy link
Contributor

tobotg commented May 14, 2023

@zasweq @dfawley Hello!
I could look into this issue if it's still available for fix. If it's ok, please feel free to assign it to me.
Thanks

@dfawley
Copy link
Member

dfawley commented May 15, 2023

Sure, that would be great if you have time for it!

@tobotg
Copy link
Contributor

tobotg commented May 23, 2023

@dfawley I've been very busy lately, hopefully I'll be able to give it a look during the weekend.

@tobotg
Copy link
Contributor

tobotg commented May 27, 2023

@dfawley I've just submitted a PR now. Please have a look when you get a chance. Thanks

tobotg added a commit to tobotg/grpc-go that referenced this issue May 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants