-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: with TLS, TCP user timeout is not set on the underlying connection #5646
Comments
Unassigning; I thought this was client-side, but it looks like the client is done correctly and only the server needs to be fixed. I probably don't have cycles for this right now. |
Sure, that would be great if you have time for it! |
@dfawley I've been very busy lately, hopefully I'll be able to give it a look during the weekend. |
@dfawley I've just submitted a PR now. Please have a look when you get a chance. Thanks |
grpc-go/internal/transport/http2_server.go
Line 235 in 60eecd9
I was looking at the write code - for net.Conn this works as expected, but if TLS is used conn will be tls.Conn so the line will
not set a timeout. I would guess rawconn should be passed ?
The text was updated successfully, but these errors were encountered: