Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go-grpc: add tests #6748

Closed
dfawley opened this issue Oct 25, 2023 · 6 comments · Fixed by #7072
Closed

protoc-gen-go-grpc: add tests #6748

dfawley opened this issue Oct 25, 2023 · 6 comments · Fixed by #7072

Comments

@dfawley
Copy link
Member

dfawley commented Oct 25, 2023

We don't currently have any tests in protoc-gen-go-grpc. We should add something simple at least:

  1. Create a .proto file with streaming / unary RPCs.
  2. Generate the .pb.go file(s) from it and commit it/them.
  3. Write a test that does (2) and diffs the results with the committed file(s).
@Aditya-Sood
Copy link
Contributor

hi @dfawley, can I pick this up?

@dfawley
Copy link
Member Author

dfawley commented Nov 7, 2023

@Aditya-Sood ?

@Aditya-Sood
Copy link
Contributor

thank you Doug, as suggested I will close the other issue and then pick this up

@miledxz
Copy link
Contributor

miledxz commented Dec 16, 2023

@dfawley , Im looking what could be done here, but Annotate from protogen has been deprecated, do we need to take that in consideration too ?

@dfawley
Copy link
Member Author

dfawley commented Dec 18, 2023

@zedGGs that seems unrelated. At the moment there are no tests, which means any changes made here have to be tested manually. If Annotate is deprecated then we should separately look into switching to whatever the alternative is, and having tests in place before making that change would help to ensure nothing is broken by the change.

@miledxz
Copy link
Contributor

miledxz commented Dec 31, 2023

@dfawley I can take this one, if thats okey for you, I will add tests for unary RPCs, and if that goes well in pull request, I can also add tests for other RPCs streaming options,

feel free to assign me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants