-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-go-grpc: add tests #6748
Comments
hi @dfawley, can I pick this up? |
thank you Doug, as suggested I will close the other issue and then pick this up |
@dfawley , Im looking what could be done here, but |
@zedGGs that seems unrelated. At the moment there are no tests, which means any changes made here have to be tested manually. If |
@dfawley I can take this one, if thats okey for you, I will add tests for unary RPCs, and if that goes well in pull request, I can also add tests for other RPCs streaming options, feel free to assign me |
We don't currently have any tests in
protoc-gen-go-grpc
. We should add something simple at least:.proto
file with streaming / unary RPCs..pb.go
file(s) from it and commit it/them.The text was updated successfully, but these errors were encountered: