Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert remaining uses of gracefulswitch to use gracefulswitch.ParseConfig and not SwitchTo #7047

Open
dfawley opened this issue Mar 19, 2024 · 2 comments
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2 Type: Internal Cleanup Refactors, etc

Comments

@dfawley
Copy link
Member

dfawley commented Mar 19, 2024

Follow-up work for #7035: convert other uses of this package.

When that is done, delete the SwitchTo method on gracefulswitch.Balancer (keeping switchTo) and also delete BalancerConfig:

type BalancerConfig struct {

@silaselisha
Copy link
Contributor

@dfawley a polite request to be assigned this task.

@dfawley
Copy link
Member Author

dfawley commented Apr 1, 2024

You're welcome to attempt it, but it could be tricky. Something from this list might be a little more new-to-grpc friendly: https://github.com/grpc/grpc-go/issues?q=is%3Aopen+label%3A%22Status%3A+Help+Wanted%22+sort%3Aupdated-desc

@purnesh42H purnesh42H added the Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. P2 Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

No branches or pull requests

3 participants