-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gracefulswitch: add ParseConfig and make UpdateClientConnState call SwitchTo if needed #7035
Conversation
…witchTo if needed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7035 +/- ##
==========================================
- Coverage 82.45% 82.31% -0.14%
==========================================
Files 299 300 +1
Lines 31314 31349 +35
==========================================
- Hits 25819 25805 -14
- Misses 4435 4471 +36
- Partials 1060 1073 +13
|
This change LGTM, what was the technical reason this came up (other than the fact this is now how Java and C does it)? Will let Arvind gate the merge though since he's official reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed
This change LGTM, what was the technical reason this came up (other than the fact this is now how Java and C does it)? Will let Arvind gate the merge though since he's official reviewer.
The reason we did this is that we had a user that wanted to delegate to a child using GSB but didn't want to have to do all the parsing logic.
cc @anicr7
This change does not migrate some users of gracefulswitch; they can be done as a follow-up: clusterimpl, outlierdetection, balancergroup.
RELEASE NOTES: none