Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: support environment variable protection for fallback #7479

Closed
easwars opened this issue Aug 5, 2024 · 0 comments · Fixed by #7483
Closed

xdsclient: support environment variable protection for fallback #7479

easwars opened this issue Aug 5, 2024 · 0 comments · Fixed by #7483
Assignees
Labels
Type: Feature New features or improvements in behavior

Comments

@easwars
Copy link
Contributor

easwars commented Aug 5, 2024

According to the xDS fallback design A71, support for the GRPC_EXPERIMENTAL_XDS_FALLBACK environment variable needs to be added:

If this variable is unset or is false, only one xDS server will be read from the bootstrap file.

It might be tricky for us to read a single server from the bootstrap file since we currently unmarshal that field into an array of JSON objects, but we could change the implementation to ignore everything but the first server if this env var is unset of false. In fact, this was the behavior before a bunch of bootstrap related changes were made to support xDS fallback.

@easwars easwars added the Type: Feature New features or improvements in behavior label Aug 5, 2024
@easwars easwars self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant