xds: env var protection for xds fallback #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7483 +/- ##
==========================================
+ Coverage 81.40% 81.54% +0.14%
==========================================
Files 357 357
Lines 27243 27259 +16
==========================================
+ Hits 22176 22229 +53
+ Misses 3850 3826 -24
+ Partials 1217 1204 -13
|
arvindbr8
approved these changes
Aug 7, 2024
Comment on lines
+1205
to
+1207
| // TODO(easwars): Default value of "GRPC_EXPERIMENTAL_XDS_FALLBACK" | ||
| // env var is currently false. When the default is changed to true, | ||
| // explicitly set it to false here. |
There was a problem hiding this comment.
optional: explicitly state what the test expects?
There was a problem hiding this comment.
This whole test is expected to be run with the env var set to false. This is stated in the name of the test and the top-level comment.
There was a problem hiding this comment.
i meant
origFallbackEnv := envconfig.XDSFallbackSupport
envconfig.XDSFallbackSupport = false
defer func() { envconfig.XDSFallbackSupport = origFallbackEnv }()
There was a problem hiding this comment.
Ah sorry. Should have done that. But now, I will just wait for the default value to change before doing that :)
infovivek2020
pushed a commit
to infovivek2020/grpc-go
that referenced
this pull request
Aug 18, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7479
#a71-xds-fallback
RELEASE NOTES: none