-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor typos #7497
Comments
@NathanBaulch i the PR you have a list of words that are spelled wrong. Can you mention that list in the issue? Also, better to send one pr word as per your list. Thanks |
Sure, here's the full list with number of occurrences:
|
I don't follow, can you clarify this request @purnesh42H? |
@NathanBaulch scratch that. Initially i was thinking we can have one pr to fix each word typo but that will be too many PRs. Can you send smaller PR that doesn't modify more than 2-3 files? If the code change is in generated interfaces, that's ok as that require each interface to be generated again |
I don't believe I touched any code generated files (assuming you mean |
It seems the tests are failing due to a reflection test (caused by the typo fix?), otherwise, let's just rip off the bandaid and merge the big PR in its current state. |
Fixed @dfawley - I've restored a couple of intentional typos in the reflection tests and everything is passing now. |
PR #7487 fixes a bunch of typos across the entire project, however it's been deemed too far reaching for a single commit from an unknown author without prior discussion. Understandable.
How should these changes be broken up? cc @purnesh42H
I admit that I didn't take the time to figure out how to install the correct protoc + plugin versions to regenerate all code (https://buf.build takes care of that in my projects) so I wouldn't be surprised if that caused some problems.
FWIW a couple of these typos have already been fixed upstream via grpc/grpc-proto#158.
For anyone curious (cc @arvindbr8), I used a combination of the excellent typos tool along with the "Typos" IntelliJ IDE inspection. Both methods produce a non-trivial number of false positives that have to be manually checked however.
The text was updated successfully, but these errors were encountered: