Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix minor typos #7487

Merged
merged 2 commits into from
Aug 14, 2024
Merged

*: fix minor typos #7487

merged 2 commits into from
Aug 14, 2024

Conversation

NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Aug 7, 2024

Fixes #7497

Just thought I'd contribute some typo fixes after the word "pancis" started tripping up CI/CD checks in my projects (already fixed via #7456). Nothing controversial (hopefully), just 122 simple fixes.

Use the following command to get a quick and dirty summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the top typos are:

  • cancelation (6)
  • ceritificate (6)
  • andcleanup (5)
  • configurated (4)
  • indaequate (3)
  • unimplemneted (3)
  • existant (3)
  • shoud (2)
  • readd (2)
  • unexpect (2)
  • aggretator (2)
  • remainining (2)
  • keealive (2)
  • certifcate (2)
  • sugned (2)
  • verfies (2)
  • fo (2)
  • shuting (2)

RELEASE NOTES: none

Copy link

linux-foundation-easycla bot commented Aug 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (366decf) to head (d76d0fa).
Report is 3 commits behind head on master.

Files Patch % Lines
internal/transport/http2_client.go 0.00% 1 Missing ⚠️
internal/xds/bootstrap/bootstrap.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7487      +/-   ##
==========================================
- Coverage   81.78%   81.67%   -0.11%     
==========================================
  Files         359      359              
  Lines       27515    27515              
==========================================
- Hits        22502    22473      -29     
- Misses       3802     3818      +16     
- Partials     1211     1224      +13     
Files Coverage Δ
balancer/grpclb/grpclb.go 82.67% <ø> (ø)
balancer/pickfirst/pickfirst.go 83.73% <ø> (ø)
balancer/rls/cache.go 87.96% <100.00%> (ø)
balancer/rls/internal/keys/builder.go 98.29% <ø> (ø)
balancer/rls/internal/test/e2e/rls_child_policy.go 88.23% <ø> (ø)
balancer/rls/picker.go 91.19% <ø> (ø)
...er/weightedtarget/weightedaggregator/aggregator.go 94.82% <ø> (ø)
clientconn.go 93.10% <ø> (ø)
credentials/alts/internal/conn/aeadrekey.go 71.42% <ø> (ø)
credentials/alts/internal/conn/aes128gcmrekey.go 78.37% <ø> (ø)
... and 28 more

... and 18 files with indirect coverage changes

@purnesh42H purnesh42H self-assigned this Aug 8, 2024
@purnesh42H
Copy link
Contributor

purnesh42H commented Aug 8, 2024

These are too many files to change in one PR. This can cause merge conflicts etc. We should probably split into smaller PRs.

Also, great that you have identified all the typos. Could you file an issue so that we can track? Thanks

@purnesh42H purnesh42H assigned NathanBaulch and unassigned purnesh42H Aug 8, 2024
@arvindbr8
Copy link
Member

We should also revert all generated code changes. Those should be fixed at source and regenerated.

@arvindbr8
Copy link
Member

just 122 simple fixes.

Wow, 122 typos? That's a lot of comma sense missing! Thanks for helping us clean up the repo.

In the tracking issue, could you also let us know how did you find all the typos here? mispell in our CI is clearly not working as intended. Fixing mispell could also be tracked in the same issue, otherwise this will bite us / other users like you in the future. Thanks!

@@ -605,9 +605,9 @@ func testFileContainingSymbol(t *testing.T, stream v1reflectiongrpc.ServerReflec

func testFileContainingSymbolError(t *testing.T, stream v1reflectiongrpc.ServerReflection_ServerReflectionInfoClient) {
for _, test := range []string{
"grpc.testing.SearchService",
"grpc.testing.SerchService",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but in the interest of not repeating this mistake, could you make these not "typos", but valid words that are just not correct?

E.g. "grpc.testing.OtherService" and "grpc.other.SearchResponse"?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, are you ok with using a couple of superfluous underscores? Force pushed and tests are passing locally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine too, thanks!

@dfawley dfawley changed the title Fix minor typos *: fix minor typos Aug 13, 2024
@dfawley dfawley assigned purnesh42H and unassigned NathanBaulch Aug 13, 2024
@purnesh42H purnesh42H self-requested a review August 14, 2024 17:12
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H purnesh42H merged commit c8951ab into grpc:master Aug 14, 2024
13 checks passed
@NathanBaulch NathanBaulch deleted the typos branch August 14, 2024 21:47
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
* Fix typos

* Fix reflecton tests
@NathanBaulch NathanBaulch mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor typos
4 participants