-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix minor typos #7487
*: fix minor typos #7487
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7487 +/- ##
==========================================
- Coverage 81.78% 81.67% -0.11%
==========================================
Files 359 359
Lines 27515 27515
==========================================
- Hits 22502 22473 -29
- Misses 3802 3818 +16
- Partials 1211 1224 +13
|
These are too many files to change in one PR. This can cause merge conflicts etc. We should probably split into smaller PRs. Also, great that you have identified all the typos. Could you file an issue so that we can track? Thanks |
We should also revert all generated code changes. Those should be fixed at source and regenerated. |
Wow, 122 typos? That's a lot of comma sense missing! Thanks for helping us clean up the repo. In the tracking issue, could you also let us know how did you find all the typos here? mispell in our CI is clearly not working as intended. Fixing mispell could also be tracked in the same issue, otherwise this will bite us / other users like you in the future. Thanks! |
@@ -605,9 +605,9 @@ func testFileContainingSymbol(t *testing.T, stream v1reflectiongrpc.ServerReflec | |||
|
|||
func testFileContainingSymbolError(t *testing.T, stream v1reflectiongrpc.ServerReflection_ServerReflectionInfoClient) { | |||
for _, test := range []string{ | |||
"grpc.testing.SearchService", | |||
"grpc.testing.SerchService", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but in the interest of not repeating this mistake, could you make these not "typos", but valid words that are just not correct?
E.g. "grpc.testing.OtherService" and "grpc.other.SearchResponse"?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, are you ok with using a couple of superfluous underscores? Force pushed and tests are passing locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's fine too, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* Fix typos * Fix reflecton tests
Fixes #7497
Just thought I'd contribute some typo fixes after the word "pancis" started tripping up CI/CD checks in my projects (already fixed via #7456). Nothing controversial (hopefully), just 122 simple fixes.
Use the following command to get a quick and dirty summary of the specific corrections made:
FWIW, the top typos are:
RELEASE NOTES: none