-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: add go.mod to make examples a separate module #3546
Conversation
Looks like the https://travis-ci.org/github/grpc/grpc-go/jobs/676263348 Please also run |
We can't do much (including running
I can add the replace rule for the purpose of testing, but of course we won't want to actually commit it. Any other suggestions? |
Can we tag this commit with |
Generated with a replace rule in place
b244acf
to
6d89ebf
Compare
FYI, with the replace rule in the |
(I'm going to remove the replace rule now) |
472689d
to
5236516
Compare
Without the replace rule, all tests pass except TESTEXTRAS, since v1.30.0-dev.1 is unknown revision: https://travis-ci.org/github/grpc/grpc-go/builds/676345662: |
How would you like to proceed? Given that all tests pass when a |
Did you try tagging your commit in your branch? I'm not sure that will work, but it might be worth a shot. Otherwise I can force merge this and then add the tag after. |
Ok, I've tagged the commit and pushed: $ git push origin v1.30.0-dev.1
Total 0 (delta 0), reused 0 (delta 0)
To https://github.com/chalin/grpc-go.git
* [new tag] v1.30.0-dev.1 -> v1.30.0-dev.1 Can you restart Travis build #9802? (I don't have the permissions to do so.) |
I kicked travis; the EXTRAS run is still failing:
I think this is because I'll do this on Monday unless anyone raises any concerns. |
Thanks for restarting the build. I also suspected that |
Still slated to try this today? |
examples
a module
@dfawley - FYI, now that this has been published, my tests work locally, w/o using the replace rule. Maybe the latest TESTEXTRAS Travis job just needs to be restarted. Could you try that? |
Hurray, the build is green! https://travis-ci.org/github/grpc/grpc-go/builds/677804973 |
Everything does seem happy now (it took a few minutes for the go sum DB to be updated, during which time I was mildly concerned)! @chalin will you be making updates to the quick start guide next? |
Yes, that is at the top of my to-do list! |
Fixes #3539
Supersedes #3540