credentials/alts: ClientAuthorizationCheck to case-fold compare of peer SA #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expectedServiceAccounts` are commonly mixed-case, while the `PeerServiceAccount` is lowel-case. The discrepancy can be error-prone, recommendation is to use Unicode case-folding comparison. Nit: change `status.Newf(...).Err()` to the semantically equal `status.Errorf(...)`.
AntonNep
changed the title
|
Can you sign the CLA, please? Thanks! |
easwars
changed the title
|
@menghanl can you please explain what clarification is required from my side? |
|
@AntonNep We were waiting for the CLA. It looks good now. |
|
Hi @cesarghali and @menghanl , is there anything blocking this PR from being approved? |
|
Sorry for the late response, this fell through the cracks for some reason. |
cesarghali
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectedServiceAccountsare commonly mixed-case, while thePeerServiceAccountis lowel-case.The discrepancy can be error-prone, recommendation is to use Unicode case-folding comparison.
Nit: change
status.Newf(...).Err()to the semantically equalstatus.Errorf(...).