-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/kokoro: install go 1.17, and retry go build #5015
Changes from 2 commits
aef3beb
7feb843
5ef3eef
bb3f70b
5aa6c0e
f1ede36
32aa96e
228443d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,13 @@ shopt -s extglob | |
branch="${branch//[[:space:]]}" | ||
branch="${branch##remotes/origin/}" | ||
shopt -u extglob | ||
go build | ||
# Install go >= 1.14 for the new features, e.g. errors.Is() | ||
sudo apt-get install -y wget | ||
wget https://go.dev/dl/go1.17.3.linux-amd64.tar.gz | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if Also, should these things be retried for the same reason as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
sudo tar -C /usr/local -xvf go1.17.3.linux-amd64.tar.gz | ||
sudo cp /usr/local/go/bin/go /usr/bin/go | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
# Retry go build on error, for at most 3 times | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mention why? (Downloading dependencies, presumably?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
for i in 1 2 3; do go build && break || sleep 5; done | ||
popd | ||
|
||
git clone -b "${branch}" --single-branch --depth=1 https://github.com/grpc/grpc.git | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment will be outdated eventually.
How about "Install a version of Go supported by gRPC"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Or you didn't want that
e.g.
?