client: log last error on subchannel connectivity change #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Mar 14, 2023
dfawley
approved these changes
Mar 15, 2023
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #5831 by logging the last error when a subchannel connectivity changes to TransientFailure.
Right now, if a grpc client uses healthchecks with misconfigured serviceName and
WithBlock()dial option it simply gets a timeout error. The problem got much worse by the fact that even with the most verbose debug logs we don't get any useful information about why the connection failed.I understand the reasons why we don't want to add the healthcheck error information to the actual error that is returned to the user code, but we can at least log this error.
RELEASE NOTES: none