Revert "Revert "credentials/alts: defer ALTS stream creation until handshake …" #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix the breakage caused by the commit (the reason we rolled back)? |
|
Thanks @zasweq! Yes this PR fixes the original problem with #6177: we check that Additionally, I've already merged #6177, which adds e2e tests that would have caught the error in #6177 before import. The tests on this PR were originally failing because the e2e test was flaky: I just merged #6183, which fixes the flake. Huge thanks again to @easwars for his help on these 2 PRs. :) |
|
Ah, good to hear! Will approve then. I ran our import already this week, so this will get picked up in next weeks import :). |
easwars
approved these changes
Apr 11, 2023
|
Thank you both! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6148.
In #6177, we added new tests that would have caught a bug like the one that forced #6077 to be reverted.
RELEASE NOTES: N/A