Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: add helpers to start test service, and retrieve port #6187

Merged
merged 1 commit into from
Apr 12, 2023
Merged

testing: add helpers to start test service, and retrieve port #6187

merged 1 commit into from
Apr 12, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Apr 11, 2023 •
edited
Loading

FYI, I could not add this helper function to the testutils package since it was causing an import cycle.

Fixes #6128.

RELEASE NOTES: none

@easwars easwars requested a review from arvindbr8 April 11, 2023 23:28
@easwars easwars added this to the 1.55 Release milestone Apr 11, 2023
@easwars
Copy link
Contributor Author

easwars commented Apr 11, 2023

@arvindbr8 : You asked for this :P

arvindbr8
arvindbr8 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Apr 12, 2023
@easwars easwars merged commit fe72db9 into grpc:master Apr 12, 2023
1 check passed
@easwars easwars deleted the testutils_helper branch April 12, 2023 16:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
1.55 Release
Development

Successfully merging this pull request may close these issues.

testing: move helper that starts a test service backend to internal/testutils
2 participants
@easwars @arvindbr8