-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: Add sleepBetweenRPCs and connections parameters #6299
Merged
Merged
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5c9f7a4
Add sleepBetweenRPCs parameter to benchmarks
s-matyukevich e4c5b51
Use random distribution
s-matyukevich 65ccca3
Remove delay from the client receive function and add it to the serve…
s-matyukevich b3d96ed
Add parameter to control the number of connections
s-matyukevich 0014165
fix linter error
s-matyukevich 88afecc
rename parameter
s-matyukevich 57a049a
fix linter error
s-matyukevich 2bf89d6
Sleep before sending the first request
s-matyukevich ff36d9e
Merge branch 'master' of github.com:grpc/grpc-go into add-sleep-to-be…
s-matyukevich 2aee78f
configure the number of connections
s-matyukevich 659b192
Merge branch 'master' of github.com:grpc/grpc-go into add-sleep-to-be…
s-matyukevich 23c1278
Skip warmup if SleepBetweenRPCs > 0, use graceful stop on the server.
s-matyukevich 3615d73
fix warmup condition
s-matyukevich 5a8d7a7
Revert s.GracefulStop() change
s-matyukevich 60ac14b
Allow codes.Canceled in unconstrained run
s-matyukevich 907b01d
Fix unconstrained mode with preloader=on
s-matyukevich 1905a66
Merge branch 'master' of github.com:grpc/grpc-go into add-sleep-to-be…
s-matyukevich accfb30
Merge branch 'master' of github.com:grpc/grpc-go into add-sleep-to-be…
s-matyukevich fa1f079
rename index parameter and import name
s-matyukevich 7d0cd0d
add messing period
s-matyukevich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, how about a flag for the number of connections, where each connection does
maxConcurrentCalls
at a time? Hopefully that wouldn't be too different implementation-wise, and would allow for some more interesting testing options.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done.