Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencensus: stop overwriting ctx parameter in tests #6350

Merged
merged 1 commit into from
Jun 6, 2023
Merged

opencensus: stop overwriting ctx parameter in tests #6350

merged 1 commit into from
Jun 6, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jun 5, 2023 •
edited
Loading

Saw this in the last import.

RELEASE NOTES: n/a

@dfawley dfawley added this to the 1.57 Release milestone Jun 5, 2023
@dfawley dfawley requested a review from zasweq June 5, 2023 20:29
zasweq
zasweq approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird this got left. I thought I deleted this and changed callsite solely to make sure tests context was used in all operations which requires timeout.

@zasweq zasweq assigned dfawley and unassigned zasweq Jun 5, 2023
@dfawley dfawley merged commit 81c513a into grpc:master Jun 6, 2023
1 check passed
@dfawley dfawley deleted the octest branch June 6, 2023 17:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@dfawley dfawley

Labels
Type: Testing
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @zasweq