client: handle empty address lists correctly in addrConn.updateAddrs #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Jun 7, 2023
test/subconn_test.go
Outdated
| } | ||
| defer ss.Stop() | ||
| if _, err := ss.Client.EmptyCall(ctx, &testpb.Empty{}); err != nil { | ||
| t.Fatalf("UnaryCall RPC failed: %v", err) |
There was a problem hiding this comment.
Sorry, super nit: UnaryCall is distinct from EmptyCall wrt StubServer. Technically it is a UnaryCall, but would prefer calling this EmptyCall.
test/subconn_test.go
Outdated
| t.Log("Re-adding addresses to resolver and SubConn") | ||
| ss.R.UpdateState(resolver.State{Addresses: []resolver.Address{{Addr: ss.Address}}}) | ||
| if _, err := ss.Client.EmptyCall(ctx, &testpb.Empty{}); err != nil { | ||
| t.Fatalf("UnaryCall RPC failed: %v", err) |
This was referenced Jun 19, 2023
zasweq
pushed a commit
to zasweq/grpc-go
that referenced
this pull request
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug caused by #6302, and will need to be cherry-picked into v1.56.x before the release.
grpclb can run into this situation, which the added test also stimulates. It may not be "proper" to have a SubConn with no addresses, but the result is currently a nil pointer panic, which we should not allow, and needs to be fixed ASAP.
RELEASE NOTES: none