xds: clusterresolver e2e test cleanup #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
force-pushed
the
clusterresolver_test_cleanup_part_2
branch
from
14d6bbd to
5aa6ed3
Compare
zasweq
approved these changes
Jun 23, 2023
Comment on lines
537
to
544
| // BackendOptions contains options to configure individual backends in a | ||
| // locality. | ||
| type BackendOptions struct { | ||
| // Port number on which the backend is accepting connections. | ||
| Port uint32 | ||
| // Health status of the backend. Default is UNKNOWN which is treated the | ||
| // same as HEALTHY. | ||
| HealthStatus v3corepb.HealthStatus |
There was a problem hiding this comment.
Nit: Still looks like on Localhost. Mention somewhere in these comments? I guess maybe we'll scale it up in future, but then you can't test locally haha.
There was a problem hiding this comment.
Thanks. Added.
Yes, we probably will never make it generic enough to run on non-localhost machines :)
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added better support for locality and backend options in the
e2epackage, and cleaned up custom endpoint resource creation logic inxds/internal/balancer/clusterresolver/e2e_test/eds_impl_test.go.#resource-agnostic-xdsclient-api
RELEASE NOTES: none