Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop/xds: improve error message #6614

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

Aditya-Sood
Copy link
Contributor

@Aditya-Sood Aditya-Sood commented Sep 10, 2023

Fixes this issue discussed in PR #6575

RELEASE NOTES: none

@easwars easwars changed the title Hotfix: Fixes typo in error message interop/xds: improve error message Sep 11, 2023
@easwars easwars added this to the 1.59 Release milestone Sep 11, 2023
@easwars
Copy link
Contributor

easwars commented Sep 11, 2023

edit: not sure why the vet-proto test is failing, VET_SKIP_PROTO=1 ./vet.sh runs fine locally

That's fine. It will not block the eventual merging of the PR. That failure just means that we need to update some of our pb.gos.

@Aditya-Sood
Copy link
Contributor Author

done, pushed the new commit to PR

@arvindbr8
Copy link
Member

LGTM. Need to get a fix out for protos.

@arvindbr8 arvindbr8 merged commit 57dcb71 into grpc:master Sep 11, 2023
9 of 10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants