Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testutils.MarshalAny #6617

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Improve testutils.MarshalAny #6617

merged 7 commits into from
Sep 18, 2023

Conversation

ulascansenturk
Copy link
Contributor

@ulascansenturk ulascansenturk commented Sep 11, 2023 •
edited
Loading

  • Used anypb.New() instead of ptypes.MarshalAny

fixes: #6611

RELEASE NOTES: N/A

@easwars easwars added this to the 1.59 Release milestone Sep 11, 2023
easwars
easwars requested changes Sep 11, 2023
View reviewed changes
internal/status/status.go Outdated Show resolved Hide resolved
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
easwars
easwars requested changes Sep 11, 2023
View reviewed changes
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/clientresources.go Outdated Show resolved Hide resolved
interop/xds/custom_lb_test.go Outdated Show resolved Hide resolved
xds/internal/resolver/xds_resolver_test.go Outdated Show resolved Hide resolved
xds/internal/server/listener_wrapper_test.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/xdsresource/filter_chain_test.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/xdsresource/unmarshal_lds_test.go Outdated Show resolved Hide resolved
internal/testutils/xds/e2e/clientresources.go Outdated Show resolved Hide resolved
@easwars
Copy link
Contributor

easwars commented Sep 12, 2023

Could you please look at the vet failure? Thanks.

easwars
easwars reviewed Sep 12, 2023
View reviewed changes
internal/testutils/marshal_any.go Outdated Show resolved Hide resolved
xds/internal/clusterspecifier/rls/rls_test.go Outdated Show resolved Hide resolved
xds/internal/clusterspecifier/rls/rls_test.go Show resolved Hide resolved
@ulascansenturk
Copy link
Contributor Author

Could you please look at the vet failure? Thanks.

fixed

@dfawley dfawley assigned easwars and unassigned ulascansenturk Sep 18, 2023
@easwars easwars merged commit 130bc42 into grpc:master Sep 18, 2023
10 checks passed
@easwars
Copy link
Contributor

easwars commented Sep 18, 2023

Thanks @ulascansenturk, for your contribution!!

@ulascansenturk ulascansenturk deleted the 6611 branch September 18, 2023 22:56
@ulascansenturk ulascansenturk mentioned this pull request Sep 18, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@easwars easwars easwars approved these changes

Assignees

@easwars easwars

Labels
Type: Testing
Projects
None yet
Milestone
1.59 Release
Development

Successfully merging this pull request may close these issues.

Improve testutils.MarshalAny
3 participants
@ulascansenturk @easwars @dfawley