Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify the dns schema for the ALTS hand-shaker. #6686

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

mjamaloney
Copy link
Contributor

@mjamaloney mjamaloney commented Oct 4, 2023

Before this change applications that override the default resolver may not be able to talk to the metadata server to start the ALTS Handshake, resulting in DirectPath not being used.

RELEASE NOTES:

  • credentials/alts: fix a bug preventing ALTS from connecting to the metadata server if the default scheme is overridden

Before this change applications that override the default resolver may
not be able to talk to the metadata server to start the ALTS Handshake,
resulting in DirectPath not being used.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mjamaloney / name: Mike Maloney (8b556ad)

@dfawley dfawley added this to the 1.59 Release milestone Oct 4, 2023
@dfawley dfawley requested a review from ginayeh October 4, 2023 16:50
@ginayeh ginayeh modified the milestones: 1.59 Release, 1.60 Release Oct 5, 2023
@ginayeh ginayeh merged commit 313861e into grpc:master Oct 10, 2023
19 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants